Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor pool connection timeout when executing queries directly in the pool #1338

Open
wants to merge 8 commits into
base: 4.x
Choose a base branch
from
Open

Honor pool connection timeout when executing queries directly in the pool #1338

wants to merge 8 commits into from
+96 −1

Commits on May 6, 2024

  1. Honor pool connection timeout when executing queries directly in the … 

    …pool.

Should fix eclipse-vertx#1232, as it now uses the timeout when acquiring the connection
    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    61c9158 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary parenthesis

    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9ed5c57 View commit details
    Browse the repository at this point in the history

  3. Some improvements: 

    - Found a pool test I could modify (but couldn't validate locally yet)
- Changed the code to return the release the connection, which wasn't happening
    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3527436 View commit details
    Browse the repository at this point in the history

  4. Fixed a typo

    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    635cc01 View commit details
    Browse the repository at this point in the history

  5. Addressed PR comments: Added an option to enable the new behavior, wh… 

    …ile still ignoring timeout for legacy clients
    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    58dc3cd View commit details
    Browse the repository at this point in the history

  6. This wasn't supposed to be checked in

    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1e2f462 View commit details
    Browse the repository at this point in the history

  7. Fixed logic

    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1a8eca6 View commit details
    Browse the repository at this point in the history

  8. Checking in generated code changes

    @pablosaavedra-rappi
    pablosaavedra-rappi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    dbb33f8 View commit details
    Browse the repository at this point in the history