Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce row values to string for Row#getString #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Coerce row values to string for Row#getString #782

wants to merge 1 commit into from
+58 −3

Conversation

aguibert
Copy link
Member

Fixes a confusing scenario that a user reported here: quarkusio/quarkus#11035

@aguibert aguibert added the backport required This issue has not been backported yet but needs to be label Sep 26, 2020
@aguibert aguibert requested a review from vietj September 26, 2020 03:54
@aguibert aguibert self-assigned this Sep 26, 2020
@vietj
Copy link
Member

vietj commented Sep 27, 2020

I am not sure this is something we want to do for free

@vietj
Copy link
Member

vietj commented Sep 27, 2020

my point is that people should know the type of the row they are retrieving and they should use the correct getter otherwise they should use getValue().toString() instead

@julianladisch
Copy link
Contributor

I agree with Julien.
The javadoc should be extended to make this clear: #802

@julianladisch
Copy link
Contributor

getValue().toString() may cause NPE.
Should we add getValueAsString that returns null for null and toString() otherwise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj Awaiting requested review from vietj

Assignees

@aguibert aguibert

Labels
backport required This issue has not been backported yet but needs to be
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aguibert @vietj @julianladisch