#55 ConfigProviderResolver lazy initialization #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ConfigProviderResolver` should not initialize on just being imported for a variety of reasons. The major reasons is makes initialization less predictable and bootstrapping more complicated. Performance is also a reason. Instead it should be initialized on access just like logging frameworks and many other Java frameworks.
|
Oh the ECA failed because I did the commit using github directly and it must have put the wrong email in.... It is such a trivial change.... I don't have anymore time to waste trying to get the ECA check happy. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigProviderResolvershould not initialize on just being imported for a variety of reasons.The major reasons is makes initialization less predictable and bootstrapping more complicated. Performance is also a reason.
Instead it should be initialized on access just like logging frameworks and many other Java frameworks.