Type-based (composed) configuration #85
Open
+330
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struberg
reviewed
Sep 6, 2018
Emily-Jiang
reviewed
Sep 6, 2018
Emily-Jiang
reviewed
Sep 6, 2018
sdaschner
force-pushed
the
issue/12-type-based-config
branch
2 times, most recently
from
0af687c to
8a0760c
Compare
|
I think that using POJOs is bringing too much complexity - we would have to either inject into private fields (not a good idea) or into constructors - in either case we have to duplicate work usually done by CDI. |
sdaschner
force-pushed
the
issue/12-type-based-config
branch
from
8a0760c to
0f9126d
Compare
Signed-off-by: Sebastian Daschner <[email protected]>
sdaschner
force-pushed
the
issue/12-type-based-config
branch
from
0f9126d to
da3c1c5
Compare
- added alternative collection lookup to zero-based indexes - removed annotation - only interfaces allowed Signed-off-by: Sebastian Daschner <[email protected]>
sdaschner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #12