Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix: improve event bus observability #4005

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

riccardomodanese
Copy link
Contributor

Brief description of the PR.
Add a flag to check if the event bus is conencted or not.

Related Issue
none

Description of the solution adopted
see brief description

Screenshots
none

Any side note on the changes made
none

@riccardomodanese riccardomodanese requested a review from Coduz March 27, 2024 15:50
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 21.09%. Comparing base (ab4b252) to head (7d79862).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4005   +/-   ##
==========================================
  Coverage      21.08%   21.09%           
  Complexity        10       10           
==========================================
  Files           1954     1954           
  Lines          41429    41430    +1     
  Branches        3801     3801           
==========================================
+ Hits            8737     8739    +2     
+ Misses         32288    32287    -1     
  Partials         404      404           
Files Coverage Δ
...artemis/plugin/security/MetricsSecurityPlugin.java 0.00% <ø> (ø)
...se/kapua/commons/event/jms/JMSServiceEventBus.java 19.21% <42.85%> (+0.37%) ⬆️

@riccardomodanese riccardomodanese force-pushed the fix-event_bus_improvement branch from ca2be9c to 7cf07e3 Compare March 28, 2024 08:10
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Apr 2, 2024
@Coduz Coduz merged commit 3025da1 into develop Apr 2, 2024
65 checks passed
@Coduz Coduz deleted the fix-event_bus_improvement branch April 2, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
Development

Successfully merging this pull request may close these issues.

2 participants