Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on MacOS ARM64 with Java 8 (Temurin). #1646

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

rgrunber
Copy link
Contributor

@rgrunber rgrunber commented May 28, 2024

On macos-latest, https://github.com/eclipse/lemminx/actions/runs/9259761464/job/25472300010 :

Error: Could not find satisfied version for SemVer '8'. 
  Available versions: 22.0.1+8, 22.0.0+36, 21.0.3+9.0.LTS, 21.0.2+13.0.LTS, 21.0.1+12.0.LTS, 21.0.0+35.0.LTS, 20.0.2+9, 20.0.1+9, 20.0.0+36, 19.0.2+7, 19.0.1+10, 19.0.0+36, 18.0.2+101, 18.0.2+9, 18.0.1+10, 18.0.0+36, 17.0.11+9, 17.0.10+7, 17.0.9+9, 17.0.8+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 17.0.0+35, 11.0.23+9, 11.0.22+7.1, 11.0.22+7, 11.0.21+9, 11.0.20+101, 11.0.20+8, 11.0.19+7, 11.0.18+10, 11.0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10
  • macos-latest is an arm64 runner, and 'temurin' has no support for this architecture on Java 8
  • Force 'x64' architecture on macos-latest since Rosetta layer should provide necessary support

See https://github.com/rgrunber/lemminx/actions/runs/9275969014 , although certain test cases are fragile.

- macos-latest is an arm64 runner, and  'temurin' has no support for
  this architecture on Java 8
- Force 'x64' architecture on macos-latest since Rosetta layer should
  provide necessary support

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber
Copy link
Contributor Author

@datho7561 , would be good if you could review this when you have time.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! The test failures now seems to be caused by the flaky tests instead of setup-java

@datho7561 datho7561 merged commit 1063ef0 into eclipse:main Jul 17, 2024
5 of 6 checks passed
@datho7561 datho7561 added this to the 0.29.0 milestone Jul 17, 2024
@rgrunber rgrunber deleted the fix-macos branch July 17, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants