Skip to content

Commit

Permalink
Merge pull request #1089 from amvanbaren/bugfix/dependency-case-sensi…
Browse files Browse the repository at this point in the history
…tive

Make unresolved dependency query case insensitive.
  • Loading branch information
amvanbaren authored Jan 28, 2025
2 parents f6d2b59 + c385f3e commit fdd1802
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public List<Extension> findAllActiveByPublicId(Collection<String> publicIds, Str
var conditions = new ArrayList<Condition>();
conditions.add(EXTENSION.PUBLIC_ID.in(publicIds));
for(var namespaceToExclude : namespacesToExclude) {
conditions.add(NAMESPACE.NAME.notEqual(namespaceToExclude));
conditions.add(NAMESPACE.NAME.notEqualIgnoreCase(namespaceToExclude));
}

var query = findAllActive();
Expand Down Expand Up @@ -242,8 +242,8 @@ public String findFirstUnresolvedDependency(List<ExtensionId> dependencies) {
var unresolvedDependency = DSL.concat(namespace, DSL.value("."), extension).as("unresolved_dependency");
return dsl.select(unresolvedDependency)
.from(ids)
.leftJoin(NAMESPACE).on(NAMESPACE.NAME.eq(namespace))
.leftJoin(EXTENSION).on(EXTENSION.NAME.eq(extension))
.leftJoin(NAMESPACE).on(NAMESPACE.NAME.equalIgnoreCase(namespace))
.leftJoin(EXTENSION).on(EXTENSION.NAME.equalIgnoreCase(extension))
.where(NAMESPACE.NAME.isNull()).or(EXTENSION.NAME.isNull())
.limit(1)
.fetchOne(unresolvedDependency);
Expand Down

0 comments on commit fdd1802

Please sign in to comment.