Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vue packages up to be directly contained in packages folder; smaller deps improvements #2162

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

lucas-koehler
Copy link
Contributor

@lucas-koehler lucas-koehler commented Jul 12, 2023

  • Move vue packages
  • Regenerate pnpm lock file and thereby also update dependencies
  • angular-material: Update karma-webpack dep. to ^4.
    • v3 is meant for webpack 3 while we use webpack 4.

Fixes #2158

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit fd486fc
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64ef5663f886fa000864f003
😎 Deploy Preview https://deploy-preview-2162--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler lucas-koehler changed the title Move vue packages up to be directly contained in packages folder WIP: Move vue packages up to be directly contained in packages folder Jul 12, 2023
- Move vue packages
- Remove obsolete build:pre and build:after scripts from vue-vanilla package
- Regenerate pnpm lock file and thereby also update dependencies

Fix #2162
Version 3.3.1 of rollup-plugin-import-css was already used.
Explicitly raise the dependency because from 3.3.0 the default behavior of generating the bundled css file name changed.
Configure example apps to always generate it as bundle.css
@coveralls
Copy link

coveralls commented Aug 30, 2023

Coverage Status

coverage: 84.469%. remained the same when pulling fd486fc on 2158-vue-packages into c1686c1 on master.

karma-webpack is meant for webpack 3 while we use webpack 4 in this package.
v2 is outdated and is implemented for legacy Node 12.
@lucas-koehler lucas-koehler changed the title WIP: Move vue packages up to be directly contained in packages folder Move vue packages up to be directly contained in packages folder, smaller deps improvements Aug 30, 2023
@lucas-koehler lucas-koehler changed the title Move vue packages up to be directly contained in packages folder, smaller deps improvements Move vue packages up to be directly contained in packages folder; smaller deps improvements Aug 30, 2023
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit fba14a4 into master Sep 1, 2023
10 checks passed
sdirix pushed a commit that referenced this pull request Sep 1, 2023
- Move vue packages
- Remove obsolete build:pre and build:after scripts from vue-vanilla package
- Regenerate pnpm lock file and thereby also update dependencies

Fix #2162
@sdirix sdirix deleted the 2158-vue-packages branch September 1, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move vue packages up to be directly contained in packages folder
3 participants