feat: remove state slice when set as undefined #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sdirix
requested changes
Jul 12, 2023
|
Sorry, I did hammer a bit the CI, I don't have the environment installed locally so I could test before committing. I hope it's good enough. |
sdirix
approved these changes
Jul 13, 2023
|
We can do an alpha release soon, so you can consume the changes 👍 |
That'd be great :) |
|
@JBBianchi |
|
This feature seems to work as expected but this alpha-0 ships the bug reported (and fixed) in #2166 so I'll wait next release to actually use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles setting a slice state to
undefinedas removing the said slice.Related to #1790