feat: added select control renderer for enums and oneOf #2264
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
Hi! Thanks for your PR ❤️ We'll try to have a look soon! |
There was a problem hiding this comment.
Hi @mhorsche , thanks again for the contribution ❤️
The control already seems to work quite well. I have some inline comments.
Please have a look at the comments and add some test cases for the new renderer in packages/angular-material/test. Generally, we require at least basic tests for every renderer.
| /* | ||
| The MIT License | ||
|
|
||
| Copyright (c) 2017-2019 EclipseSource Munich |
There was a problem hiding this comment.
| Copyright (c) 2017-2019 EclipseSource Munich | |
| Copyright (c) 2024 EclipseSource Munich |
| return { | ||
| const: el.const, | ||
| label: el.title ? el.title : el.const, | ||
| // disabled: el.readOnly ? true : false, |
There was a problem hiding this comment.
Can this be removed?
| <mat-option | ||
| *ngFor="let option of optionElements" | ||
| [value]="option.const" | ||
| [disabled]="option.disabled ? true : false" |
There was a problem hiding this comment.
Can this be removed?
| ) | ||
| ); | ||
|
|
||
| interface OptionOfSelect { |
There was a problem hiding this comment.
Instead of defining a new type, I think we can reuse the EnumOption type from @jsonforms/core. The disabled property does not seem to be needed after all.
| /* change scope to items of the array */ | ||
| scope = scope.items as JsonSchema; | ||
| } | ||
| console.log(scope); |
There was a problem hiding this comment.
Is this a leftover from development? It should likely be removed
|
|
||
| export const SelectControlRendererTester: RankedTester = rankWith( | ||
| 5, | ||
| /* Can be used for simple Enums or OneOf, autocomplete functionallity needs autocomplete.rederer */ |
There was a problem hiding this comment.
| /* Can be used for simple Enums or OneOf, autocomplete functionallity needs autocomplete.rederer */ | |
| /* Can be used for simple Enums or OneOf, autocomplete functionality needs autocomplete.renderer */ |
Added
<mat-select>control for enum and oneOf types. Enable multi-selection for array type. Not sure if RankedTester ist properly defined, could need help with that.