Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECC-2038: GRIB: Update to param limits to include new paramIds #299

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

mjg41
Copy link
Collaborator

@mjg41 mjg41 commented Mar 3, 2025

Updated the param limits data checker to rearrange by paramId and include some new values, largely informed by what has been done for the data quality checker in the DestinE ClimateDT.
https://jira.ecmwf.int/browse/ECC-2038

@mjg41 mjg41 requested a review from shahramn March 3, 2025 14:47
@mjg41 mjg41 self-assigned this Mar 3, 2025
@shahramn shahramn changed the title feature/ECC-2038-param-limits ECC-2038: GRIB: Update to param limits to include new paramIds Mar 3, 2025
@shahramn shahramn assigned shahramn and unassigned shahramn and mjg41 Mar 3, 2025
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Mar 3, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (7aadbe0) to head (d744fb1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #299   +/-   ##
========================================
  Coverage    87.60%   87.60%           
========================================
  Files          843      843           
  Lines        62195    62195           
  Branches     11109    11109           
========================================
  Hits         54484    54484           
  Misses        7711     7711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn merged commit 98a9a0b into develop Mar 3, 2025
178 of 184 checks passed
@shahramn shahramn deleted the feature/ECC-2038-param-limits branch March 3, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants