ED-4619: Apply L3 Proving changes for ROUTES-1-6-L3 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwhitton
changed the title
added 2 commits
January 8, 2025 13:46
nknavkal
reviewed
Jan 9, 2025
| @@ -1,6 +1,6 @@ | |||
| /* -*- c-basic-offset: 4 -*- */ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.26; | |||
| pragma solidity ^0.8.28; | |||
There was a problem hiding this comment.
not relevant to your PR but i think we should combine IProver and ISimpleProver
nknavkal
reviewed
Jan 9, 2025
nknavkal
reviewed
Jan 9, 2025
nknavkal
reviewed
Jan 9, 2025
| // Output slot for the game status (aaaaa) | ||
| uint256 internal constant L2_FAULT_DISPUTE_GAME_STATUS_SLOT = 0; | ||
|
|
||
| struct FaultDisputeGameStatusSlotData { |
There was a problem hiding this comment.
im overthinking this but how do you feel about the structs being in here? the pure functions for sure absolutely make sense, but the structs to me look a bit odd in a library. If you wanna check out what I did for the Intents type I think that makes the most sense, I stole it from uniswap - kinda makes a file of structs that can be imported individually. But also this is totally fine
nknavkal
reviewed
Jan 9, 2025
nknavkal
reviewed
Jan 9, 2025
| } | ||
|
|
||
| proveStorageBytes32( | ||
| require( |
There was a problem hiding this comment.
could put this in the prover library or even a more general utils library since its just about encoding
nknavkal
requested changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.