Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export modal is open by default on mobile devices #6

Closed
edelstone opened this issue Aug 17, 2020 · 2 comments
Closed

Export modal is open by default on mobile devices #6

edelstone opened this issue Aug 17, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@edelstone
Copy link
Owner

edelstone commented Aug 17, 2020

On my iPhone using Safari, the export modal is open when the page loads. Additionally the dialog is empty, and cannot be closed. This makes the site unusable on the iPhone and maybe other mobile devices.

@ziyafenn Take a look at this and let me know if you can fix. I may have to roll back #5 if not. My apologies for not checking before merging this.

IMG_521751D7D90F-1

@edelstone edelstone added bug Something isn't working help wanted Extra attention is needed labels Aug 17, 2020
@ziyafenn
Copy link
Contributor

@edelstone i'll take a look tonight. I'm working now on a sketch plugin that can use the exported JSON to create a color palette inside Sketch. I'll create an issue for that too :)

@edelstone
Copy link
Owner Author

If the tabindex stuff you did on that last commit in #5 is causing the problem, just revert it and I'll make a new issue to investigate tabbing accessibility across the entire app. That's probably a better strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants