-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to support dialog bug on iOS #7
Conversation
I see a few issues with this @ziyafenn.
Take a look and get back to me. |
Looking again, the second problem may predate these recent PRs. Seems new though. |
@edelstone yeah, two files changes, css file (i set About the second issue, i didn't touch any global variables. Only things related to modal, button and textarea. And i think I've noticed that behaviour previously as well. |
@ziyafenn Would you mind pulling the recent changes from Below is what I see on my end. Pretty sure you kept working on your branch without pulling recent changes we already merged. |
@edelstone sorry, forgot to first pull the changes from your master. Can you please check if everything works. If yes, you can accept the PR. |
Fixed iOS bug with dialog appearing always on top.
Also, removed
tabindex="1"
from theexportButton
because on iOS it would automatically focus/scroll down to that button.p.s. sorry for linter, it decided to prettify code again...
Only thing i change is how the modal being displayed.
#6