Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to support dialog bug on iOS #7

Merged
merged 8 commits into from
Aug 18, 2020
Merged

Conversation

ziyafenn
Copy link
Contributor

@ziyafenn ziyafenn commented Aug 17, 2020

Fixed iOS bug with dialog appearing always on top.

Also, removed tabindex="1" from the exportButton because on iOS it would automatically focus/scroll down to that button.

p.s. sorry for linter, it decided to prettify code again...

Only thing i change is how the modal being displayed.

#6

@edelstone
Copy link
Owner

edelstone commented Aug 17, 2020

I see a few issues with this @ziyafenn.

  1. There are two conflicting files that need resolution (linter related?).
  2. I'm noticing that when the page loads the "color copied to clipboard" message is present at the bottom, and all of the circled color swatches transition from square to circle. Maybe there is a new CSS rule specifying a transition for all?

Take a look and get back to me.

@edelstone
Copy link
Owner

Looking again, the second problem may predate these recent PRs. Seems new though.

@ziyafenn
Copy link
Contributor Author

ziyafenn commented Aug 17, 2020

@edelstone yeah, two files changes, css file (i set display:none by default to the modal) and export.js to utilize than new css property.

About the second issue, i didn't touch any global variables. Only things related to modal, button and textarea. And i think I've noticed that behaviour previously as well.

@edelstone
Copy link
Owner

edelstone commented Aug 17, 2020

@ziyafenn Would you mind pulling the recent changes from edelstone:master and merge those with your branch so you can resolve the conflicts locally and then push again?

Below is what I see on my end. Pretty sure you kept working on your branch without pulling recent changes we already merged.

Screen Shot 2020-08-17 at 6 15 34 PM

@ziyafenn
Copy link
Contributor Author

@edelstone sorry, forgot to first pull the changes from your master.

Can you please check if everything works. If yes, you can accept the PR.

@edelstone edelstone merged commit 5e4350d into edelstone:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants