Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graph-gateway): use graphql-http crate client #404

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Oct 12, 2023

This PR aims to update some of the different "rudimentary" GraphQL client implementations to the new reqwest extension trait-based client recently merged into the toolshed repository.

  • Moved the cost model GraphQL requests next to the other indexer requests. And ported the cost model requests to use the new client.
  • Ported all indexer status requests to use the new client.
  • Updated and extended tests accordingly.

The subgraph client port has been split into a separate PR.

@LNSD LNSD self-assigned this Oct 12, 2023
@LNSD LNSD force-pushed the chore-use-graphql-http-crate-client branch 3 times, most recently from af1f37f to 8c9ac44 Compare October 31, 2023 16:19
@LNSD LNSD force-pushed the chore-use-graphql-http-crate-client branch 4 times, most recently from cac2461 to 9bb59b7 Compare November 13, 2023 15:35
@LNSD LNSD force-pushed the chore-use-graphql-http-crate-client branch from 9bb59b7 to 4a616a7 Compare November 14, 2023 15:59
@LNSD LNSD requested a review from Theodus November 14, 2023 16:12
@LNSD LNSD marked this pull request as ready for review November 14, 2023 16:12
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LNSD LNSD merged commit 334e911 into main Nov 16, 2023
2 checks passed
@LNSD LNSD deleted the chore-use-graphql-http-crate-client branch November 16, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants