Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multirange Support #73

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Multirange Support #73

merged 2 commits into from
Nov 1, 2023

Conversation

quinchs
Copy link
Collaborator

@quinchs quinchs commented Oct 10, 2023

Summary

This PR adds the MultiRange<T> datatype as well as the backing codecs/descriptors.

@quinchs quinchs marked this pull request as ready for review October 31, 2023 17:21
@quinchs quinchs requested review from scotttrinh and nsidnev October 31, 2023 17:21
Copy link
Member

@nsidnev nsidnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if this is already there and I couldn't find it, but how this PR handles multirange for old protocol. I understand that in theory this situation just should not happen, because multirange is 4.0 feature as 2.0 protocol as well, but in python, for example, this case is taken into account and for non 2.0 version the descriptor is handled in the old way

We probably don't need it, just want to make sure it was done intentionally

@quinchs
Copy link
Collaborator Author

quinchs commented Oct 31, 2023

I didn't add it to v1 protocol since it isn't available there, I can add it if there's a case that It's available in <=v1

@nsidnev
Copy link
Member

nsidnev commented Oct 31, 2023

Well, the only way to use multirange with 1.0 is when the client explicitly requests that protocol version support from the EdgeDB 4 server. If that option doesn't exist, I think we're good here.

@quinchs quinchs merged commit dd17a6c into dev Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants