Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new EdgeDBConnection.Create function #91

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Add new EdgeDBConnection.Create function #91

merged 4 commits into from
Jan 30, 2025

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Jan 29, 2025

  • Also implement shared connection tests.

@dnwpark dnwpark force-pushed the shared-client-tests branch 2 times, most recently from faddfe3 to 57ab4f0 Compare January 29, 2025 22:56
@dnwpark dnwpark requested a review from mmastrac January 29, 2025 22:57
@dnwpark dnwpark force-pushed the shared-client-tests branch from 57ab4f0 to 4e501cb Compare January 29, 2025 23:00
mmastrac
mmastrac approved these changes Jan 30, 2025
View reviewed changes
Copy link

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwpark dnwpark force-pushed the shared-client-tests branch from 4e501cb to e4ad62d Compare January 30, 2025 16:40
@dnwpark dnwpark merged commit 5638467 into dev Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnwpark @mmastrac