Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edgedb-load-ext.py to the install.list #110

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add edgedb-load-ext.py to the install.list #110

merged 3 commits into from
Sep 17, 2024

Conversation

msullivan
Copy link
Member

Is this all that's needed?

fantix
fantix approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@fantix fantix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm looks like get_exposed_commands() is called under deb/rpm builds, why the revert?

@elprans
Copy link
Member

elprans commented Sep 16, 2024

hmm looks like get_exposed_commands() is called under deb/rpm builds, why the revert?

get_exposed_commands() is for stuff that should be installed into /usr/bin as opposed to /usr/lib/edgedb-server-/../bin. I don't think this helper is worthy of being in PATH since it's intended to be called by other tools not users directly?

@msullivan msullivan merged commit ad142a4 into master Sep 17, 2024
2 checks passed
@msullivan msullivan deleted the load-ext branch September 17, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

@elprans elprans Awaiting requested review from elprans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msullivan @elprans @fantix