Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve strings handling #117

Merged
merged 2 commits into from
Nov 5, 2024
Merged

perf: Improve strings handling #117

merged 2 commits into from
Nov 5, 2024

Conversation

KokaKiwi
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

  • Replace Regex usage in SDK url handling by simple string manipulations
  • Replace multiple Regex instantiations in Sec-CH-UA HTTP header parser by a single "lazy static" instantiated on first-use only

@SachaMorard SachaMorard merged commit 2aed3bf into main Nov 5, 2024
2 checks passed
@SachaMorard SachaMorard deleted the perf/regex-usage branch November 5, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SachaMorard SachaMorard SachaMorard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KokaKiwi @SachaMorard