feat: no more html attributes, everything is now in the sdk #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KokaKiwi
approved these changes
Nov 12, 2024
SachaMorard
force-pushed
the
feat/no-more-html-attributes
branch
from
cfee2bd
to
9f0333f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
We change the way edgee “talks” to the javascript sdk.
Previously, edgee added html parameters to the sdk's script tag to pass it instructions. Now, edgee directly modifies the content of the sdk to change variable values. This is a more dynamic way of guiding the sdk from edge.
Related Issues
No related issue