Skip to content

ci: Add clippy to CI #59

ci: Add clippy to CI

ci: Add clippy to CI #59

GitHub Actions / clippy failed Oct 21, 2024 in 0s

42 warnings

clippy found 42 warnings

Annotations

Check warning on line 109 in src/proxy/proxy.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/proxy.rs#L89-L109

this `if` statement can be collapsed

Check warning on line 487 in src/proxy/proxy.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/proxy.rs#L478-L487

this `if` statement can be collapsed

Check warning on line 96 in src/tools/cacheable.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/tools/cacheable.rs#L92-L96

this `if` statement can be collapsed

Check warning on line 1 in src/config/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/config/mod.rs#L1

module has the same name as its containing module

Check warning on line 1 in src/proxy/compute/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/mod.rs#L1

module has the same name as its containing module

Check warning on line 97 in src/proxy/compute/compute.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/compute.rs#L97

called `unwrap` on `data_collection_events` after checking its variant with `is_some`

Check warning on line 116 in src/proxy/compute/compute.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/compute.rs#L116

doc list item without indentation

Check warning on line 2 in src/proxy/compute/data_collection/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/data_collection/mod.rs#L2

module has the same name as its containing module

Check warning on line 414 in src/proxy/compute/data_collection/data_collection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/data_collection/data_collection.rs#L414

`to_string` applied to a type that implements `Display` in `format!` args

Check warning on line 567 in src/proxy/compute/data_collection/data_collection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/data_collection/data_collection.rs#L567

redundant closure

Check warning on line 32 in src/proxy/compute/data_collection/payload.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/data_collection/payload.rs#L32

this expression creates a reference which is immediately dereferenced by the compiler

Check warning on line 35 in src/proxy/compute/data_collection/payload.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/data_collection/payload.rs#L35

this expression creates a reference which is immediately dereferenced by the compiler

Check warning on line 197 in src/proxy/compute/data_collection/payload.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/data_collection/payload.rs#L197

you seem to want to iterate on a map's values

Check warning on line 301 in src/proxy/compute/html.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/compute/html.rs#L301

this expression creates a reference which is immediately dereferenced by the compiler

Check warning on line 121 in src/proxy/context/proxy.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/context/proxy.rs#L121

redundant closure

Check warning on line 158 in src/proxy/context/proxy.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/context/proxy.rs#L158

redundant closure

Check warning on line 1 in src/proxy/controller/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/mod.rs#L1

module has the same name as its containing module

Check warning on line 32 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L32

this expression creates a reference which is immediately dereferenced by the compiler

Check warning on line 32 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L32

this expression creates a reference which is immediately dereferenced by the compiler

Check warning on line 36 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L36

length comparison to zero

Check warning on line 63 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L63

unneeded late initialization

Check warning on line 87 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L87

length comparison to zero

Check warning on line 96 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L96

length comparison to zero

Check warning on line 149 in src/proxy/controller/controller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/controller/controller.rs#L149

called `unwrap` on `inlined_sdk` after checking its variant with `is_ok`

Check warning on line 4 in src/proxy/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

src/proxy/mod.rs#L4

module has the same name as its containing module