Skip to content

Commit

Permalink
fix security rule reconcilation on azure
Browse files Browse the repository at this point in the history
  • Loading branch information
elchead committed Oct 22, 2024
1 parent 96ac712 commit 6d3133d
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions terraform/infrastructure/azure/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -227,27 +227,6 @@ resource "azurerm_network_security_group" "security_group" {
location = var.location
resource_group_name = var.resource_group
tags = local.tags

dynamic "security_rule" {
# we keep this rule for one last release since the azurerm provider does not
# support moving security rules that are inlined (like this) to the external resource one.
# Even worse, just defining the azurerm_network_security_group without the
# "security_rule" block will NOT remove all the rules but do nothing.
# TODO(@3u13r): remove the "security_rule" block in the next release after this code has landed.
# So either after 2.19 or after 2.18.X if cherry-picked release.
for_each = [{ name = "konnectivity", priority = 1000, port = 8132 }]
content {
name = security_rule.value.name
priority = security_rule.value.priority
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_port_range = "*"
destination_port_range = security_rule.value.port
source_address_prefix = "*"
destination_address_prefix = "*"
}
}
}

resource "azurerm_network_security_rule" "nsg_rule" {
Expand Down

0 comments on commit 6d3133d

Please sign in to comment.