Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: support to declaratively set attestation policy #1954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jun 21, 2023

Context

Until now, we used a hacky patching mechanism to update the attestation policy of the MAA to disable secure boot checking. With my PR to the Azure Terraform provider, this can be replaced with using a corresponding field in the Terraform resource.

Proposed change(s)

  • Replace the policy patching by directly specifying the attestation policy when creating / migrating a cluster.

Related issue

Additional info

To test:

  1. Clone my fork of the Azure Terraform provider
  2. Build the provider binary with make build
  3. Add the following to ~/.terraformrc:
provider_installation {

 # Use /home/developer/go/bin as an overridden package directory
 # for the hashicorp/azurerm provider. This disables the version and checksum
 # verifications for this provider and forces Terraform to look for the
 # azurerm provider plugin in the given directory.
 dev_overrides {
   "hashicorp/azurerm" = "/home/developer/go/bin" 
   # Or whatever other path theTerraform provider binary you've built in step 2 lives in. (usually $GOBIN)
 }

 # For all other providers, install them directly from their origin provider
 # registries as normal. If you omit this, Terraform will _only_ use
 # the dev_overrides block, and so no other providers will be available.
 direct {}
}
  1. Check out this branch in your Constellation workspace and create a cluster on Azure.
  2. Remember to revert the changes to ~/.terraformrc when you're done testing.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added hold This cannot be merged right now no changelog Change won't be listed in release changelog labels Jun 21, 2023
@msanft msanft added this to the v2.9.0 milestone Jun 21, 2023
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 286ff81
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6492cd4232dab70008148164

@msanft msanft changed the title feat: support to declaratively set attestation policy cli: support to declaratively set attestation policy Jun 21, 2023
@katexochen katexochen removed their request for review June 21, 2023 10:16
@daniel-weisse
Copy link
Member

@msanft The PR and issue were merged/fixed yesterday.
Judging by the schedule of their past releases, we should hopefully see a release with your changes in the next 3-4 days.

@msanft
Copy link
Contributor Author

msanft commented Jul 4, 2023

@msanft The PR and issue were merged/fixed yesterday. Judging by the schedule of their past releases, we should hopefully see a release with your changes in the next 3-4 days.

Yes, unfortunately they only merged support for the SEV-SNP attestation type though, we need to wait for Azure/azure-rest-api-specs#24635 to get merged before then again suggesting a change to the Terraform provider.. :(
If better suited, I can convert this to a draft until then

@malt3 malt3 modified the milestones: v2.9.0, v2.10.0 Jul 10, 2023
@elchead elchead removed this from the v2.10.0 milestone Aug 11, 2023
@elchead
Copy link
Contributor

elchead commented Oct 22, 2024

@msanft The PR and issue were merged/fixed yesterday. Judging by the schedule of their past releases, we should hopefully see a release with your changes in the next 3-4 days.

Yes, unfortunately they only merged support for the SEV-SNP attestation type though, we need to wait for Azure/azure-rest-api-specs#24635 to get merged before then again suggesting a change to the Terraform provider.. :( If better suited, I can convert this to a draft until then

This issue is still open, so I think this is still blocked? (Asking since I was requested for review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold This cannot be merged right now no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants