Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions: add k8s 1.31, remove k8s 1.28 #3396

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

versions: add k8s 1.31, remove k8s 1.28 #3396

wants to merge 6 commits into from
+367 −157

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Oct 8, 2024 •
edited
Loading

Context

Kubernetes v1.31.0 was released on 2024-08-13.

Proposed change(s)

  • Add 1.31.1
  • Drop 1.28
  • Only use kubeadm.k8s.io/v1beta4 for cluster config - it's supported since v1.28 and v1.31 defaults to using it.
  • Pull OpenStack CCM images from registry.k8s.io, because they are not published to docker.io anymore.
  • Pull k8s binaries from dl.k8s.io because they are not published to storage.googleapis.com anymore.
  • Sort nodes to update such that control-plane nodes are upgraded before worker nodes.

Additional info

  • AB#4728
  • Any additional information or context

Checklist

@burgerdev burgerdev added the dependencies Pull requests that update a dependency file label Oct 8, 2024
@burgerdev burgerdev added this to the v2.19.0 milestone Oct 8, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit d5860bf
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67892dd38f4ae40008414564
😎 Deploy Preview https://deploy-preview-3396--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burgerdev burgerdev requested a review from msanft October 9, 2024 05:59
@burgerdev burgerdev marked this pull request as ready for review October 9, 2024 05:59
burgerdev
burgerdev commented Oct 9, 2024
View reviewed changes
.github/workflows/e2e-test-daily.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-internal-lb.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-marketplace-image.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-terraform-provider.yml Outdated Show resolved Hide resolved
internal/versions/versions.go Show resolved Hide resolved
@3u13r
Copy link
Member

3u13r commented Oct 9, 2024 •
edited
Loading

gcp,1:2, to K8s 1.31.1 upgrade: https://github.com/edgelesssys/constellation/actions/runs/11252167053
EDIT:

Does that even work? I created #3397 so that we can test 1.30 -> 1.31.

Yeah, I missed that.

@burgerdev
Copy link
Contributor Author

gcp,1:2, to K8s 1.31.1 upgrade: https://github.com/edgelesssys/constellation/actions/runs/11252167053

Does that even work? I created #3397 so that we can test 1.30 -> 1.31.

@burgerdev burgerdev force-pushed the burgerdev/k8s-1.31 branch 2 times, most recently from 0df582f to c70bdc4 Compare October 9, 2024 14:00
elchead
elchead approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked my files

@burgerdev burgerdev modified the milestones: v2.19.0, v2.20.0 Oct 10, 2024
@burgerdev burgerdev added hold This cannot be merged right now blocked Blocked by an external cause and removed dependencies Pull requests that update a dependency file hold This cannot be merged right now labels Oct 10, 2024
This was referenced Oct 17, 2024
Closed
Draft
elchead
elchead approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owned files lgtm

@msanft msanft removed this from the v2.20.0 milestone Dec 4, 2024
@msanft msanft added this to the v2.21.0 milestone Dec 4, 2024
@burgerdev burgerdev force-pushed the burgerdev/k8s-1.31 branch 2 times, most recently from eb20368 to eb60fdc Compare December 23, 2024 10:46
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
bootstrapper/internal/kubernetes/k8sapi 13.10% 14.00% ↗️
internal/constellation/kubecmd 62.40% 75.50% ↗️
internal/versions 9.70% 9.70% 🚧
operators/constellation-node-operator/controllers 30.80% 31.60% ↗️

@burgerdev burgerdev added feature This introduces new functionality and removed blocked Blocked by an external cause labels Jan 16, 2025
@burgerdev
Copy link
Contributor Author

Unfortunately, d5860bf does not work: if a node from the worker scaling group manages to join the cluster, it will be paired with an existing worker nonetheless.

@burgerdev burgerdev added the blocked Blocked by an external cause label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@msanft msanft msanft approved these changes

@elchead elchead elchead approved these changes

@3u13r 3u13r 3u13r approved these changes

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

Assignees
No one assigned
Labels
blocked Blocked by an external cause feature This introduces new functionality
Projects
None yet
Milestone
v2.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@burgerdev @3u13r @elchead @msanft @daniel-weisse