Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeinstaller: compare with the template file content #1186

Merged
merged 1 commit into from
Jan 27, 2025
Merged

nodeinstaller: compare with the template file content #1186

merged 1 commit into from
Jan 27, 2025

Conversation

burgerdev
Copy link
Contributor

This should fix the nightly test failures that fail waiting for the coordinator to come up, explained in detail in the code comments.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Jan 24, 2025
@burgerdev burgerdev requested a review from 3u13r January 24, 2025 19:41
@burgerdev burgerdev marked this pull request as ready for review January 24, 2025 19:41
@3u13r 3u13r requested a review from katexochen January 27, 2025 02:56
katexochen
katexochen approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@burgerdev burgerdev merged commit ff6bfe1 into main Jan 27, 2025
12 checks passed
@burgerdev burgerdev deleted the burgerdev/containerd-tmpl branch January 27, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @katexochen