charts: add EDG_COORDINATOR_PROMETHEUS_ADDR to helm #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
approved these changes
Feb 28, 2023
Comment on lines
+86
to
+87
| - containerPort: {{ .Values.coordinator.prometheusPort }} | ||
| name: prometheus |
There was a problem hiding this comment.
Not that familiar with Promtheus, should this port be exposed over a Kubernetes service, or does prometheus collect from the Pod directly?
There was a problem hiding this comment.
Sorry about the delay.
After an internal discussion (started by your question) with a coworker we agreed on implementing it with an exposed Kubernetes service. Would you be interested in a PR like that?
There was a problem hiding this comment.
Yes, you can just update this PR please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR allows the configuration of the Prometheus exporter from Helm charts.