improve tests and build CI infrastructure #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids the need to replace content in the Dockerfile using sed and makes it possible to run a quick test using `make quicktest` (using the defaults for the build arguments specified in the Dockerfile)
This reduces the test runtime from about 5min to 3min on my machine.
… and $TEST_LOCAL_PKG/$TEST_PYPI_PKG
this tests in two ways: - install the package locally in each major os/architecture combination supported by GitHub Actions, then run `editorconfig-checker --version` like `run-tests.sh` does - running `run-tests.sh` once in an ubuntu machines The workflow is triggered both by pushes to any of the branches and for each pull request.
|
Thanks for your work here, really useful. I will try to review the changes next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at the recent regression I think it is a good idea to run tests one every change. This way we should no longer accidentally publish a release that does not work for our users.
The tests done are twofold:
run-tests.sh: using the default python installation, install the local package and then runec --versionto ensure a working binary has become available. This is matrixed over the platforms GitHub Actions provides: ubuntu both x64 and arm64, MacOS 13 (the last Intel variant) and 15 (arm64 M1), and lastly x64 Windows (sadly no ARM support there yet).make teston an Ubuntu 24.04 runner, verifying that our backwards compatibility to all python releases is intact.