Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46]: style names were updated #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Inferato
Copy link

@Inferato Inferato commented Jul 7, 2022

As a result of openedx/paragon#1385
$level-{level}-box-shadow scss variables have been reamed to $box-shadow-down-{level}, these changes need to reflected i edx.org theme repository

AC

  • in edx.org theme repo rename $level-{level}-box-shadow scss variables have toto $box-shadow-down-{level}

@openedx-webhooks
Copy link

Thanks for the pull request, @Inferato!

When this pull request is ready, tag your edX technical lead.

Comment on lines +382 to +385
$box-shadow-down-1: 0px 2px 8px 0px rgba(0,0,0,0.15), 0px 2px 4px 0px rgba(0,0,0,0.15);
$box-shadow-down-2: 0px 4px 10px 0px rgba(0,0,0,0.15), 0px 8px 16px 0px rgba(0,0,0,0.15);
$box-shadow-down-3: 0px 8px 20px 0px rgba(0,0,0,0.15), 0px 10px 20px 0px rgba(0,0,0,0.15);
$box-shadow-down-4: 0px 8px 48px 0px rgba(0,0,0,0.15), 0px 20px 40px 0px rgba(0,0,0,0.15);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to how we kept the original $level-X-box-shadow SCSS variables in the core Paragon theme for backwards compatibility, we may want to also leave the original variable definitions here, with a comment that their usage is deprecated.

Maybe something along the lines of:

$box-shadow-down-1:  0px 2px 8px 0px rgba(0,0,0,0.15), 0px 2px 4px 0px rgba(0,0,0,0.15);

// deprecated in favor of `$box-shadow-{side}-{level}`
$level-1-box-shadow: $box-shadow-down-1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants