Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Switch to method+handler Datadog resource name format #9

Merged
merged 1 commit into from
May 20, 2024

Conversation

timmc-edx
Copy link
Member

Replaces all instances of DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT with DD_DJANGO_USE_HANDLER_RESOURCE_FORMAT. Now resource names will be prefixed with the HTTP method, like
GET lms.djangoapps.branding.views.index.

This is not ideal and loses us some precision in the resource name but gives us something more readable, writable, and pronounceable. See edx/edx-arch-experiments#620 for more background.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

Replaces all instances of `DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT` with
`DD_DJANGO_USE_HANDLER_RESOURCE_FORMAT`. Now resource names will be
prefixed with the HTTP method, like
`GET lms.djangoapps.branding.views.index`.

This is not ideal and loses us some precision in the resource name but
gives us something more readable, writable, and pronounceable. See
edx/edx-arch-experiments#620 for more background.
@timmc-edx timmc-edx merged commit 4a0d959 into master May 20, 2024
4 checks passed
@timmc-edx timmc-edx deleted the timmc/dd-resource-method branch May 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants