fix: Address PR comments

edx · Jul 16, 2024 · 2502758 · 2502758
1 parent bd5f250
commit 2502758
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/core/src/edx/org/openedx/core/ui/theme/Colors.kt b/core/src/edx/org/openedx/core/ui/theme/Colors.kt
@@ -116,8 +116,8 @@ val dark_text_primary_light = Color(0xFF707070) // Gray 500
 val dark_text_hyper_link = Color(0xFF00688D) // Info 500
 
 val dark_text_secondary = Color.White
-val dark_text_dark = Color(0xFFF2F0EF) // Light 300
-val dark_text_warning = Color(0xFFF2F0EF) // Light 300
+val dark_text_dark = dark_text_primary
+val dark_text_warning = Color(0xFF002121) // primary 700
 
 val dark_text_accent = Color(0xFF03C7E8) // Accent A Isotope Blue
 val dark_text_field_background = dark_surface

diff --git a/core/src/main/java/org/openedx/core/ui/IAPUI.kt b/core/src/main/java/org/openedx/core/ui/IAPUI.kt
@@ -35,7 +35,8 @@ import org.openedx.core.ui.theme.appTypography
 fun ValuePropUpgradeFeatures(modifier: Modifier = Modifier, courseName: String) {
     Column(
         modifier = modifier
-            .padding(all = 16.dp)
+            .background(color = MaterialTheme.appColors.background)
+            .padding(all = 16.dp),
     ) {
         Text(
             modifier = Modifier.padding(vertical = 32.dp),
@@ -66,7 +67,7 @@ fun CheckmarkView(text: String) {
             modifier = Modifier.padding(end = 16.dp),
             imageVector = Icons.Filled.Check,
             contentDescription = null,
-            tint = MaterialTheme.appColors.certificateForeground
+            tint = MaterialTheme.appColors.successGreen
         )
         Text(
             modifier = Modifier.weight(1f),