fix: Address PR comments-2

edx · Feb 4, 2025 · e84a72d · e84a72d
1 parent 940c691
commit e84a72d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.../src/main/java/org/openedx/discussion/presentation/comments/DiscussionCommentsFragment.kt b/.../src/main/java/org/openedx/discussion/presentation/comments/DiscussionCommentsFragment.kt
@@ -181,7 +181,7 @@ class DiscussionCommentsFragment : Fragment() {
                 var fromNotificationNavigation by rememberSaveable {
                     mutableStateOf(viewModel.responseId.isNotEmpty() && viewModel.commentId.isNotEmpty())
                 }
-                LaunchedEffect(uiState is DiscussionCommentsUIState.Success) {
+                LaunchedEffect(uiState) {
                     if (uiState is DiscussionCommentsUIState.Success && fromNotificationNavigation) {
                         val commentsData =
                             (uiState as DiscussionCommentsUIState.Success).commentsData

diff --git a/...on/src/main/java/org/openedx/discussion/presentation/threads/DiscussionThreadsFragment.kt b/...on/src/main/java/org/openedx/discussion/presentation/threads/DiscussionThreadsFragment.kt
@@ -185,7 +185,7 @@ class DiscussionThreadsFragment : Fragment() {
                     mutableStateOf(threadId.isNotEmpty())
                 }
 
-                LaunchedEffect(uiState is DiscussionThreadsUIState.Threads) {
+                LaunchedEffect(uiState) {
                     if (uiState is DiscussionThreadsUIState.Threads && fromNotificationNavigation) {
                         val data = (uiState as DiscussionThreadsUIState.Threads).data
                         data.find { it.id == threadId }?.let {