fix: Handle units with no descendants #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle UI if an unit has zero descendant - show unit list if a subsection have more then 1 units.
omerhabib26
requested review from
dixidroid,
farhan-arshad-dev and
HamzaIsrar12
dixidroid
approved these changes
Aug 7, 2024
farhan-arshad-dev
requested changes
Aug 12, 2024
| @@ -852,7 +852,7 @@ fun SubSectionUnitsTitle( | |||
| onUnitsClick: () -> Unit, | |||
| ) { | |||
| val textStyle = MaterialTheme.appTypography.titleMedium | |||
| val hasUnits = unitsCount > 0 | |||
| val hasUnits = unitsCount > 1 | |||
There was a problem hiding this comment.
better to rename this with hasMultipleUnits.
Comment on lines
+265
to
+282
| if (unitBlocks.size > 1) { | ||
| val selectedUnitIndex = unitBlocks.indexOfFirst { it.id == viewModel.unitId } | ||
| OpenEdXTheme { | ||
| SubSectionUnitsList( | ||
| unitBlocks = unitBlocks, | ||
| selectedUnitIndex = selectedUnitIndex | ||
| ) { index, unit -> | ||
| if (index != selectedUnitIndex) { | ||
| router.navigateToCourseContainer( | ||
| fm = requireActivity().supportFragmentManager, | ||
| courseId = viewModel.courseId, | ||
| unitId = unit.id, | ||
| mode = requireArguments().serializable(ARG_MODE)!! | ||
| ) | ||
|
|
||
| } else { | ||
| handleUnitsClick() | ||
| } |
There was a problem hiding this comment.
Without this code-change we can achieve the required error screen.
There was a problem hiding this comment.
This code change restricts this view to trigger only when it has multiple units.
There was a problem hiding this comment.
The condition deserves some doc string.
farhan-arshad-dev
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: