Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notifications Preferences Screen #76

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

HamzaIsrar12
Copy link

Description

LEARNER-10345

Add Push Notification settings to the profile, allowing users to manage permissions for discussion notifications.

Screenshots

Settings Screen Push Notifications Screen

Config

PR: https://github.com/edx/edx-mobile-config/pull/188

Base automatically changed from 2U/farhan_ar/notifications_module to 2U/develop December 24, 2024 06:15
@HamzaIsrar12 HamzaIsrar12 force-pushed the hamza/LEARNER-10345 branch 2 times, most recently from 2fe7568 to aac27bc Compare December 24, 2024 12:40
Copy link

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some minor nits

@HamzaIsrar12 HamzaIsrar12 self-assigned this Jan 6, 2025
Copy link
Collaborator

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job

@HamzaIsrar12 HamzaIsrar12 merged commit 2613dd0 into 2U/develop Jan 9, 2025
3 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-10345 branch January 9, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants