fix: Resolve logical issues with analytics triggering #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MyCourses or MyPrograms screen event was being triggered whenever uiState updated, as it was being collected in the ViewModel. Fixed this by linking it to the tap click event instead.
Some events were being triggered on orientation change since most were placed in onCreate block. Moved them to the ViewModel's init block to resolve the issue.
The Course Tab events weren't being triggered when navigating via a deeplink; they were only triggered on click events.
farhan-arshad-dev
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Learner-10439
MyCoursesorMyProgramsscreen event was triggered whenever uiState updated, as it was being collected in the ViewModel. We fixed this by linking it to the tap-click event instead.Launch,Identify,Permission Status&Course Dashboard) were triggered when the orientation changed since most were placed in theonCreateblock. I moved them to the ViewModel'sinitblock to resolve the issue.