Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elm-token: Adding elm tokens desing for poc #1

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

ochavarria2u
Copy link
Collaborator

No description provided.

Copy link
Contributor

@srwang srwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the readme also explain that this was based off of brand-edx? (or give a quick history of why we split off to using elm - historical knowledge for future devs?)

README.rst Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ochavarria2u ochavarria2u requested a review from srwang April 4, 2024 21:49
README.rst Outdated
@edx/elm-edx.org
==================

This project contains branding assets and themes for edx.org. It is the edX implementation of the branding interface defined in `@edx/brand-openedx <https://[email protected]/edx/brand-openedx>`_. Note that we aim to avoid introducing any breaking changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe the marketing site implementation? brand-openedx is an edx implementation too

@ochavarria2u ochavarria2u merged commit d27c637 into main Apr 5, 2024
3 checks passed
@ochavarria2u ochavarria2u deleted the elm-tokens branch May 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants