-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adopt DTCG format, fix color scales, add build:watch, update typography tokens #24
base: main
Are you sure you want to change the base?
Conversation
"paragon:help": "paragon help" | ||
}, | ||
"devDependencies": { | ||
"@openedx/paragon": "22.0.0-alpha.25" | ||
"@openedx/paragon": "file:../paragon/openedx-paragon-20.18.1.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[inform] Requires changes that are under review in Paragon alpha
. Using local package for now via npm pack
.
f4031ae
to
2a9bc6e
Compare
@@ -19,9 +19,11 @@ | |||
"build-tokens": "paragon build-tokens --source ./tokens/src --build-dir ./paragon/css --source-tokens-only", | |||
"build-scss": "paragon build-scss --corePath ./paragon/core.scss --themesPath ./paragon/css/themes --defaultThemeVariants light", | |||
"build": "make build", | |||
"build:watch": "nodemon --ignore dist -x \"make build\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running npm run build:watch
will automatically re-build the tokens/theme, resulting in updated dist
output on updates to files. Useful when referencing the locally built files from Paragon during local development, or just more streamlined rapid development.
0f0c67e
to
3022751
Compare
e09263d
to
dd4cf7b
Compare
bbe3716
to
67b862b
Compare
67b862b
to
f618f9d
Compare
Note: Accounts for changes to Paragon
alpha
in related PRs:Figma
Paragon Elm Theme
Changes
style-dictionary
officially supports it. This involves migratingvalue
->$value
,type
->$type
, etc.build:watch
NPM script.tokens/src/core/global/typography.json
to reflect updates to upstream typography tokens, including ensuring the font size scale for display 1-4 works on mobile type.accent-a
andaccent-b
, despite a scale being depicted in Elm theme Figma. The upstream Paragon design system does not have a level scale (100-900) foraccent-a
andaccent-b
, so the elm-theme tokens are now updated to match.Screenshots
Color swatches from Paragon docs site
Updated support for mobile-specific sizes per display level 1-4