fix: adopt DTCG format, fix color scales, add build:watch, update typography tokens #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Sep 1, 2024
| "paragon:help": "paragon help" | ||
| }, | ||
| "devDependencies": { | ||
| "@openedx/paragon": "22.0.0-alpha.25" | ||
| "@openedx/paragon": "file:../paragon/openedx-paragon-20.18.1.tgz", |
There was a problem hiding this comment.
[inform] Requires changes that are under review in Paragon alpha. Using local package for now via npm pack.
adamstankiewicz
force-pushed
the
ags/tokens-updates
branch
from
f4031ae to
2a9bc6e
Compare
adamstankiewicz
commented
Sep 1, 2024
| @@ -19,9 +19,11 @@ | |||
| "build-tokens": "paragon build-tokens --source ./tokens/src --build-dir ./paragon/css --source-tokens-only", | |||
| "build-scss": "paragon build-scss --corePath ./paragon/core.scss --themesPath ./paragon/css/themes --defaultThemeVariants light", | |||
| "build": "make build", | |||
| "build:watch": "nodemon --ignore dist -x \"make build\"", | |||
There was a problem hiding this comment.
Running npm run build:watch will automatically re-build the tokens/theme, resulting in updated dist output on updates to files. Useful when referencing the locally built files from Paragon during local development, or just more streamlined rapid development.
adamstankiewicz
force-pushed
the
ags/tokens-updates
branch
2 times, most recently
from
0f0c67e to
3022751
Compare
adamstankiewicz
changed the title
adamstankiewicz
force-pushed
the
ags/tokens-updates
branch
6 times, most recently
from
e09263d to
dd4cf7b
Compare
10 tasks
adamstankiewicz
force-pushed
the
ags/tokens-updates
branch
8 times, most recently
from
bbe3716 to
67b862b
Compare
10 tasks
adamstankiewicz
force-pushed
the
ags/tokens-updates
branch
from
67b862b to
f618f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Accounts for changes to Paragon
alphain related PRs:Figma
Paragon Elm Theme
Changes
style-dictionaryofficially supports it. This involves migratingvalue->$value,type->$type, etc.build:watchNPM script.tokens/src/core/global/typography.jsonto reflect updates to upstream typography tokens, including ensuring the font size scale for display 1-4 works on mobile type.accent-aandaccent-b, despite a scale being depicted in Elm theme Figma. The upstream Paragon design system does not have a level scale (100-900) foraccent-aandaccent-b, so the elm-theme tokens are now updated to match.Screenshots
Color swatches from Paragon docs site
Updated support for mobile-specific sizes per display level 1-4