fix: add more forgiving timeout duration for sdn backup (#87)

* fix: add more forgiving timeout duration for sdn backup * chore: quality
edx · Dec 19, 2024 · d00ba77 · d00ba77
1 parent 0999877
commit d00ba77
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/sanctions/apps/sanctions/management/commands/populate_sdn_fallback_data_and_metadata.py b/sanctions/apps/sanctions/management/commands/populate_sdn_fallback_data_and_metadata.py
@@ -53,7 +53,7 @@ def handle(self, *args, **options):
         # download the CSV locally, to check size and pass along to import
         threshold = options['threshold']
         url = settings.CONSOLIDATED_SCREENING_LIST_URL
-        timeout = settings.SDN_CHECK_REQUEST_TIMEOUT
+        timeout = settings.SDN_BACKUP_REQUEST_TIMEOUT
 
         with requests.Session() as s:
             try:

diff --git a/sanctions/apps/sanctions/management/commands/tests/test_download_sdn_fallback.py b/sanctions/apps/sanctions/management/commands/tests/test_download_sdn_fallback.py
@@ -151,7 +151,7 @@ def test_timeout_exception(self):
                     self.LOGGER_NAME,
                     'WARNING',
                     "Sanctions SDNFallback: DOWNLOAD FAILURE: Timeout occurred trying to download SDN CSV. "
-                    "Timeout threshold (in seconds): 5"
+                    "Timeout threshold (in seconds): 15"
                 )
             )
 

diff --git a/sanctions/settings/base.py b/sanctions/settings/base.py
@@ -97,6 +97,7 @@ def root(*path_fragments):
 
 # SDN Check
 SDN_CHECK_REQUEST_TIMEOUT = 5  # Value is in seconds.
+SDN_BACKUP_REQUEST_TIMEOUT = 15  # Value is in seconds.
 # Settings to download the government CSL
 CONSOLIDATED_SCREENING_LIST_URL = 'https://data.trade.gov/downloadable_consolidated_screening_list/v1/consolidated.csv'
 # Settings to check government purchase restriction lists