-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tp8 docker maintenance #149
Conversation
@@ -88,7 +78,7 @@ COPY --from=tei /tmp/*.xar /exist/autodeploy/ | |||
|
|||
WORKDIR /exist | |||
|
|||
ARG ADMIN_PASS=none | |||
# ARG ADMIN_PASS=none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using docker compose I tend to pass a password for admin. Why disable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ll get to the compose file, its more a question of how to pass / set an admin password, the old way relied on a shell, the new way will not
enable mutli-arch images add dependabot.yml close #150
the changes to the GitHub action script are meant to maintain previous behaviour. We will only see it in action properly with the release though, with a new git tag, on master, new registry, etc. There are a number of questions do we want to target raspberry pi in addition to what we have now? do we ant to add more tags eg for branches or prs? do we want to add additional labels (or any), do we want to stick with only publishing from master branch? I m not a big fan of the Do we want to change the image name to |
rm node after shakespear build changes
Version updates to various dependencies in devcontainer and dockerfile.
Switch to
duncdrum/existdb
base image in Dockerfile, currently install DEMO apps from open PRs for compatibilitysee eeditiones/shakespeare#8
see eeditiones/vangogh#2
Use J8 instead of J17 for exist 6.2.0
streamlined and updated GitHub action scripts
for a dry run see eeditiones/tei-publisher-ner#4
close https://github.com/eeditiones/tei-publisher-planning/issues/36
Going to take a look at the Docker-compose now
see eeditiones/teipublisher-docker-compose#5
see eeditiones/teipublisher-docker-compose#4
Please test both devcontainers and dockerfiles for your workflows.
Changes:
no more shell (could switch to debug images for that)
automatic updates of stock expaths app inside existdb on top of os and java updates
switched from alpine to Debian for greater consistency
ADMIN_PASS
clear text variable no longer in usemulti-arch builds for arm and intel