Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tp8 docker maintenance #149

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Tp8 docker maintenance #149

merged 6 commits into from
Mar 16, 2023

Conversation

duncdrum
Copy link
Contributor

@duncdrum duncdrum commented Mar 8, 2023

Version updates to various dependencies in devcontainer and dockerfile.

Switch to duncdrum/existdb base image in Dockerfile, currently install DEMO apps from open PRs for compatibility
see eeditiones/shakespeare#8
see eeditiones/vangogh#2

Use J8 instead of J17 for exist 6.2.0

streamlined and updated GitHub action scripts

for a dry run see eeditiones/tei-publisher-ner#4

close https://github.com/eeditiones/tei-publisher-planning/issues/36

Going to take a look at the Docker-compose now
see eeditiones/teipublisher-docker-compose#5
see eeditiones/teipublisher-docker-compose#4

Please test both devcontainers and dockerfiles for your workflows.

Changes:
no more shell (could switch to debug images for that)
automatic updates of stock expaths app inside existdb on top of os and java updates
switched from alpine to Debian for greater consistency
ADMIN_PASS clear text variable no longer in use
multi-arch builds for arm and intel

@@ -88,7 +78,7 @@ COPY --from=tei /tmp/*.xar /exist/autodeploy/

WORKDIR /exist

ARG ADMIN_PASS=none
# ARG ADMIN_PASS=none
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using docker compose I tend to pass a password for admin. Why disable it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ll get to the compose file, its more a question of how to pass / set an admin password, the old way relied on a shell, the new way will not

Dockerfile Outdated Show resolved Hide resolved
@duncdrum
Copy link
Contributor Author

duncdrum commented Mar 8, 2023

the changes to the GitHub action script are meant to maintain previous behaviour. We will only see it in action properly with the release though, with a new git tag, on master, new registry, etc.

There are a number of questions do we want to target raspberry pi in addition to what we have now? do we ant to add more tags eg for branches or prs? do we want to add additional labels (or any), do we want to stick with only publishing from master branch?

I m not a big fan of the master tag being updated for every push to master, but latest sticking with a static version of the last full release. But changing this might create more headaches than it solves.

Do we want to change the image name to editions/teipublisher?

rm node after shakespear build changes
@duncdrum duncdrum marked this pull request as ready for review March 8, 2023 20:22
@wolfgangmm wolfgangmm merged commit 686cfd3 into master Mar 16, 2023
@windauer windauer deleted the tp8-docker-maintenance branch March 16, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants