Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python to create a docker-compose ??? #5

Open
duncdrum opened this issue Mar 8, 2023 · 1 comment
Open

Python to create a docker-compose ??? #5

duncdrum opened this issue Mar 8, 2023 · 1 comment
Labels
question Further information is requested

Comments

@duncdrum
Copy link

duncdrum commented Mar 8, 2023

What's the benefit of that, shouldn't the docker-compose.yml be able to stand on its own?

I also don't see why we are configuring exist version, the tea-publisher images come with an exist (and java) version. So instead of hyper coding that here, we could put tags on the teipublisher images, if we want to allow teipublished v 7.1.2 with exist 5.1.2 but also with exist 6.1.0 etc. Can be done, but frankly I think people should simple pull teipublisher:7.1.2 and automatically get one installed in the latest version instance teipublisher 7.1.2 is compatible with.

Nginx and teipublisher should be a given,

NER is optional, but I don't see the problem with having that simply inlined.

there are a few more places where we are not utilising the default abilities for using --secrets or --mounts for ssh certs etc that we should have a look at.

@duncdrum duncdrum added the question Further information is requested label Mar 8, 2023
@wolfgangmm
Copy link
Member

wolfgangmm commented Mar 8, 2023

The purpose of this repository is to quickly host a custom edition generated by TEI Publisher, not tei-publisher-app itself. This includes the nginx setup, acquiring a certificate for SSL etc. Therefore you need to customize various parameters as described in the README. Doing this manually costs 15 to 30 minutes and is error prone. Therefore I'd like to have a script do it for me. We're currently running half a dozen editions this way and I'd like to be able to quickly fire up a new service without having to edit nginx configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants