Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to ignore the MigrationHistory table from the naming conventions #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EraYaN
Copy link

@EraYaN EraYaN commented Feb 11, 2021

I put some tests in for now that should test the column names. (And the table name, but that doesn't change).

Not sure if this is the right way to go with the FullName test against a string, but it seems quite unlikely to have a name collision there.

Closes #1

@cbordeman
Copy link

Please merge this! When I first apply the naming conventions extension, I am seeing:

SELECT migration_id, product_version
FROM "__EFMigrationsHistory"
ORDER BY migration_id;

column "migration_id" does not exist

@EraYaN
Copy link
Author

EraYaN commented Aug 3, 2021

@roji Thoughts? Is this a direction that might make it into the code base?

@EraYaN
Copy link
Author

EraYaN commented Oct 20, 2021

Resolved the merge conflicts.

@EraYaN
Copy link
Author

EraYaN commented Jan 17, 2022

Made the tests make sense.

@EraYaN
Copy link
Author

EraYaN commented Jan 17, 2022

@roji This is now properly ready I think

@roji
Copy link
Member

roji commented Jan 19, 2022

I'll try to take a look at this in the coming week or two, thanks.

@peterbomers
Copy link

Is it possible to merge this PR?
We want to use the namening convention plugin for existing databases and we don't want to migrate the migration history table.

Thanks in advance!

@EraYaN
Copy link
Author

EraYaN commented Nov 10, 2022

I have rebased this to the latest 7.0.0 version.

@steingran
Copy link

I bumped into this exact issue, which is a very annoying problem. @roji any chance you could take a look at this PR and potentially approve running the workflows on the PR? Then we can get one step further toward a solution.

@roji
Copy link
Member

roji commented Nov 15, 2022

Everyone, sorry I haven't been able to look at this PR (or the problem it attempts to fix). The 7.0 release is currently taking up most of my time, once things quiet down I'll try to look at this.

Thanks for your patience.

@EraYaN
Copy link
Author

EraYaN commented Jan 17, 2023

I have rebased this to the latest 7.0.2 version.

@EraYaN
Copy link
Author

EraYaN commented May 26, 2023

@roji Did you have a chance to take a look at this PR?

@EraYaN
Copy link
Author

EraYaN commented Dec 12, 2023

Would it be possible to get this one in for the 8.0 version? @bricelam

@EraYaN
Copy link
Author

EraYaN commented Jan 11, 2024

I have rebased this for 8.0.2 on current main.

@EraYaN
Copy link
Author

EraYaN commented Feb 2, 2024

Rebased this to 8.0.3 (current main)

@steingran
Copy link

@roji Any chance we could progress on this PR? @EraYaN has done a great job rebasing it on the latest versions of EF Core as time (and versions) has gone by

@roji
Copy link
Member

roji commented Apr 4, 2024

@steingran unfortunately there's not much chance I'll be able to find time for this in the near future. I traditionally do a concentrated spike of work near the end of the release, i.e. for EFCore.NamingConventions 9.0 - that should happen in a few months. I do promise to give this issue priority when I do...

@peterbomers
Copy link

@steingran unfortunately there's not much chance I'll be able to find time for this in the near future. I traditionally do a concentrated spike of work near the end of the release, i.e. for EFCore.NamingConventions 9.0 - that should happen in a few months. I do promise to give this issue priority when I do...

Is it possible to include this (.NET) 9.0 version?
(it allows me to cleanup some ugly code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__EFMigrationsHistory columns are snake_cased, upgrading needs manual alter script
5 participants