Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tblte project #10

Open
wants to merge 2 commits into
base: xiaomi/aries
Choose a base branch
from
Open

Add tblte project #10

wants to merge 2 commits into from

Conversation

micky387
Copy link

This is project for Samsung Galaxy Note Edge for international ,tmo and other variant

This is project for Samsung Galaxy Note Edge for international ,tmo and other variant
@M1cha
Copy link
Member

M1cha commented Mar 30, 2017

can you quickly confirm if this is fully working and that you tested everything?(multiple variants, bootloaders, sdcard support, etc).

Also, I'll have to rebase the tree and push it manually since you based on and pushed into xiaomi/aries.

@micky387
Copy link
Author

micky387 commented Mar 30, 2017

Not tested on all variant but working on international (tblte ,tbltexx ,tbltedt) tbltetmo and other i think yes,it's the same base (i'm the maintainers of Resurrection Remix rom for note edge) .

If you want,i can push again in the right place ??
just close this and add it again...
best regards

@M1cha
Copy link
Member

M1cha commented Mar 31, 2017

you can't PR new branches but it's ok and I can do it myself since I have your code now.
but first explicitly answer these questions please:

  • does the sdcard work in UEFI ?(it shouldn't since apq8084 doesn't has support for it yet)
  • do new rom's (6.x, especially the stock rom's) of the device use DT too or do they use appended fdt?
  • did you test the app, and did you successfully multiboot some ROM's?

I have to ask questions, because some people try to make devices official which aren't 100% stable and working.

@micky387
Copy link
Author

ok

1/No sdcard in UEFI
2/ yes always dt.img
3 i have always the same issue when i try to run start_local_otaserver PORT

start_local_otaserver PORT
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/lib/python2.7/SimpleHTTPServer.py", line 235, in
test()
File "/usr/lib/python2.7/SimpleHTTPServer.py", line 231, in test
BaseHTTPServer.test(HandlerClass, ServerClass)
File "/usr/lib/python2.7/BaseHTTPServer.py", line 600, in test
port = int(sys.argv[1])
ValueError: invalid literal for int() with base 10: 'PORT'

@abraha2d
Copy link

abraha2d commented Mar 31, 2017

@M1cha This device tree is the same as the trlte device tree. Would it not be easier to just add tblte variants to the OTA server, pointing at the trlte build? AFAIK the Note Edge is just the Note 4 with a curved display on one side. Same underlying device.

abraha2d/ota@8df8e76

I have a user testing my Note 4 build on a Note Edge right now...

@abraha2d
Copy link

And @micky387, you're not supposed to run start_local_otaserver PORT literally. Substitute a 4-5 digit number (less than 65535) for PORT (e.g. start_local_otaserver 3343) 😄

@micky387
Copy link
Author

1/ no,tblte have different dt.img.
The size of tblte are 2560x1600 and note 4 2560x1440 failing that it's the same phone (exceted 2/3 things)

2/ oh,ok i'm tired me....

@M1cha
Copy link
Member

M1cha commented Mar 31, 2017

@abraha2d which means I merged your device without asking you if the SD works :D bad me :P

@abraha2d
Copy link

abraha2d commented Mar 31, 2017

@M1cha but you said it's ok if the sd doesn't work... because there's no sd support for apq8084...

@M1cha
Copy link
Member

M1cha commented Mar 31, 2017

@abraha2d maybe we misunderstood each other. adding sd support is usually easy. I'll look at it when I have time but it's like a 5min patch for me.

@abraha2d
Copy link

abraha2d commented Mar 31, 2017

@micky387 oh, ok. i didn't notice the different dt.img... sorry...
Let me check it, to see the differences...

@micky387
Copy link
Author

micky387 commented Apr 2, 2017

@abraha2d
I see already some user of note edge use your personal work .
If it's working,i dont need to work for tblte variant,you're release are fine ??

@abraha2d
Copy link

abraha2d commented Apr 2, 2017

Just saw the success... Ya, note 4 builds seem to be working on the note edge, even with the different dt.img... 🤷‍♂️

@micky387
Copy link
Author

micky387 commented Apr 2, 2017

ok so i can close this project.

Best regards

@micky387 micky387 closed this Apr 2, 2017
@micky387 micky387 reopened this Apr 5, 2017
@micky387
Copy link
Author

micky387 commented Apr 5, 2017

Hello.
I reopen this project.
I have tested @abraha2d 's build and it's working great but break all sensors hubs . Rotation sensors and auto brightness will break.
On my build,it's working great. So dt.img are really different

Regards and all credits to @abraha2d for initial build

@abraha2d
Copy link

abraha2d commented Apr 6, 2017

Ya, @M1cha and I have reached the conclusion to keep trlte and tblte as different devices, as the dt.img's are not mergable...

Quick question, is your dt.img pulled from the latest stock ROM?

@micky387
Copy link
Author

micky387 commented Apr 6, 2017

I'm building dt.img from last kernel source (in same time with resurrection remix Rom for note edge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants