Closes #316 (Was dropping rest of proof) #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n choice and bad drop of `rest_if_proof`
|
This PR seems to be overlooked... @oflatt maybe you could take a look? |
oflatt
approved these changes
Jul 29, 2024
|
@eytans would love to merge this if you have time to fix a small conflict! |
|
@oflatt Sure. You can merge now |
SaltyPeppermint
pushed a commit
to SaltyPeppermint/egg
that referenced
this pull request
Aug 30, 2024
Closes egraphs-good#316 (Was dropping rest of proof)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for existance + fix bad connection choice and… bad drop of
rest_if_proofI think this is a full fix, but to be honest I am not sure exactly how everything works, so I hope I am not breaking anything.
cargo testpasses, and I did run make, but couldn't run with features="lp".