Add Keck Lyot stop in L band #171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivalaginja
added a commit
to vkooten/hcipy
that referenced
this pull request
Feb 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 80.73% 80.32% -0.41%
==========================================
Files 95 95
Lines 7060 7097 +37
==========================================
+ Hits 5700 5701 +1
- Misses 1360 1396 +36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ivalaginja
force-pushed
the
keck_lyot_stop_L_band
branch
from
76f8ac8
to
40dcb37
Compare
|
@vkooten @ivalaginja What's the progress on this? Have those details been figured out? |
|
Unfortunately I believe this is a dead-end PR without a plan forward. We could reach out to @vkooten offline to check with her, but in my opinion this can be closed without merging. |
|
@ivalaginja Reached out to @vkooten on a hopefully current email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to here from #155 since @vkooten and I weren't sure about how exactly to deal with some details of the Lyot stop and we want to merge the Keck aperture asap.