Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the BIC sampling fractions #1664

Merged

Conversation

mhkim-anl
Copy link
Contributor

Briefly, what does this PR introduce?

Sampling fractions of the BIC ScFi and imaging layers have been updated using 5 GeV electrons generated at eta = 0. Only the constant sampling fractions are provided this time. The energy- and eta-dependent ones will be provided next time referring to the comments on the last BIC sampling fraction PR.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

Sampling fractions of BIC ScFi and imaging layers have been updated using 5 GeV electrons generated at eta = 0.
@mhkim-anl mhkim-anl linked an issue Nov 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: barrel labels Nov 2, 2024
@mhkim-anl
Copy link
Contributor Author

I'm sorry for not writing the issue number. This PR is related to issue #1661.

@veprbl veprbl added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 10184fa Nov 4, 2024
84 of 86 checks passed
@veprbl veprbl deleted the 1661-sampling-fraction-updates-for-bic-scfi-and-imaging-layers branch November 4, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sampling fraction updates for BIC ScFi and imaging Layers
2 participants