fix: depend on datamodel version headers in datamodel glue #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Aug 14, 2023
veprbl
reviewed
Aug 15, 2023
This will force rebuilding of the datamodel glue headers in local development copies when the data model changes version.
Co-authored-by: Dmitry Kalinkin <[email protected]>
See key4hep/EDM4hep#152 for name change.
This reverts commit 0e2d899.
wdconinc
force-pushed
the
datamodel-glue-depends-on-edm4hep-edm4eic-version
branch
from
48cb940
to
0f0d5b6
Compare
veprbl
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This will force rebuilding of the datamodel glue headers in local development copies when the data model changes version.
Depends on:
update minimum required EDM4hep version to 0.9(compatibility is ensured by febc5f7)update minimum required EDM4hep version to 2.1(compatibility is ensured by febc5f7 )What kind of change does this PR introduce?
cmake --freshdoes not rebuild datamodel glue header when switching datamodel versions)Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.