Artifact events #52
Merged
Artifact events #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
commented
Aug 30, 2024
andmat900
reviewed
Aug 30, 2024
|
|
||
| def close(self): | ||
| """Close the RabbitMQ publisher if it is started.""" | ||
| if self.publisher is not None and self.publisher.is_alive(): |
There was a problem hiding this comment.
log a message if any of this fails?
There was a problem hiding this comment.
There should be enough logging from eiffel-pythonlib for RabbitMQ errors. It is quite verbose so adding more logs would be very noisy.
fredjn
previously approved these changes
Sep 16, 2024
There was a problem with the file log.json, where it got changed after a checksum had been created causing the checksum verification to fail on the client side. We now read the content so that the file cannot be modified before publishing.
t-persson
force-pushed
the
artifact-events
branch
from
25ead23
to
df35fc3
Compare
|
Force pushed as I had to rebase. The only change is updating "str" to "bytes" in a docstring. Will merge if checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
Publish Artifact and Report events on the internal messagebus when uploading files.
Alternate Designs
None!
Possible Drawbacks
None!
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]