forked from axelarnetwork/axelar-amplifier
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sol msg verifier logic (and add cache) #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we iterate per each message, doing the necessary RPC calls and making the vote decision. The RPC client is now caching requested transactions. Per each message, we search in all sol tx logs, as each tx can hold multiple messages.
eloylp
commented
Mar 4, 2024
tilacog
reviewed
Mar 4, 2024
tilacog
approved these changes
Mar 4, 2024
tilacog
reviewed
Mar 4, 2024
Co-authored-by: tilacog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #7. It accomplishes the following:
Vec<Vote>
was being overwritten, resulting in incorrect votation. It would be beneficial to allocate additional time to implement unit tests for this functionality. Here we are only fixing the production code.Review Tip: Please review each commit separately.