Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rust implementation for some of the Cairo types #18

Merged
merged 4 commits into from
Apr 29, 2024
Merged

feat: rust implementation for some of the Cairo types #18

merged 4 commits into from
Apr 29, 2024

Conversation

ctoyan
Copy link
Member

@ctoyan ctoyan commented Apr 24, 2024

Description

Implements #77 in the giza-axelar-starknet repository.
Adds Rust representations for some Cairo types.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Run the unit tests.

@ctoyan ctoyan changed the title feat: Rust implementation for some Cairo types feat: Rust implementation for some of the Cairo types Apr 24, 2024
@ctoyan ctoyan changed the title feat: Rust implementation for some of the Cairo types feat: rust implementation for some of the Cairo types Apr 24, 2024
puhtaytow
puhtaytow approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@puhtaytow puhtaytow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

tomekpiotrowski
tomekpiotrowski suggested changes Apr 25, 2024
View reviewed changes
ampd/src/starknet/types/array_span.rs Outdated Show resolved Hide resolved
ampd/src/starknet/types/array_span.rs Show resolved Hide resolved
ampd/src/starknet/types/byte_array.rs Outdated Show resolved Hide resolved
@ctoyan ctoyan mentioned this pull request Apr 25, 2024
Merged
4 tasks
@ctoyan ctoyan self-assigned this Apr 29, 2024
@ctoyan
Copy link
Member Author

ctoyan commented Apr 29, 2024

Test pass and clippy passes locally.
I presume that the CI doesn't pass, because Axelar use a custom workflow runner and in our organisation the tasks just stay queued and are never picked up.

@ctoyan ctoyan merged commit 176dbd5 into starknet Apr 29, 2024
1 of 5 checks passed
@ctoyan ctoyan deleted the feat/cairo-types branch April 29, 2024 16:40
ctoyan added a commit that referenced this pull request Jun 10, 2024
@ctoyan
feat: rust implementation for some of the Cairo types (#18)
8fa4034
ctoyan added a commit that referenced this pull request Jun 10, 2024
@ctoyan
feat: rust implementation for some of the Cairo types (#18)
e2ce7c2
ctoyan added a commit that referenced this pull request Aug 7, 2024
@ctoyan
feat: rust implementation for some of the Cairo types (#18)
7cdfe85
ctoyan added a commit that referenced this pull request Sep 9, 2024
@ctoyan
feat: rust implementation for some of the Cairo types (#18)
9bf055a
ctoyan added a commit that referenced this pull request Sep 9, 2024
@ctoyan
feat: rust implementation for some of the Cairo types (#18)
5f10e7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekpiotrowski tomekpiotrowski tomekpiotrowski approved these changes

@puhtaytow puhtaytow puhtaytow approved these changes

Assignees

@ctoyan ctoyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctoyan @tomekpiotrowski @puhtaytow