feat: update solana deps #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzox
reviewed
Sep 13, 2024
| @@ -11784,7 +11784,7 @@ version = "0.1.9" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "cf221c93e13a30d793f7645a0e7762c55d169dbb0a49671918a2319d289b10bb" | |||
| dependencies = [ | |||
| "windows-sys 0.59.0", | |||
| "windows-sys 0.48.0", | |||
There was a problem hiding this comment.
Not that I want to go through the lock file to understand this 😅 , but curious about these downgrades 🤔
There was a problem hiding this comment.
ahhh yeah. To be honest, i do not understand it either. at some point in the dependency tree a final resolved one changed probably. But i am speculating here 😅
There was a problem hiding this comment.
We are mergin to a development branch, lets just merge it. Its a common practice to remove the lock file and allow cargo recreate it each time we bring changes from upstream, as it has conflicts...
frenzox
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just updated the solana dependencies to point to the latest
maincommit, in which a change in a submodule url of the deps resides - Now we use http instead of SSH.