feat: lazily infer max chunk size on write #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilacog
changed the title
tilacog
changed the title
tilacog
commented
Dec 30, 2024
crates/solana-gateway-task-processor/src/component/message_payload.rs
Outdated
Show resolved
Hide resolved
roberts-pumpurs
previously approved these changes
Jan 6, 2025
tilacog
changed the title
tilacog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Lazily compute the max chunk size allowed per
WriteMessagePayloadinstruction, as to optimize the number of required transactions to send the message payload.Reviewer notes
Just a heads up about the commit history - there are some old commits that'll disappear after squashing. Only the latest commit (d80fc01) matters here. The current diff accurately shows the final changes, though. I probably branched from an outdated version - my mistake on that.